ooni / probe-cli / 6305154612

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(enginenetx): stabilize happy eyeballs algorithm (#1301)

* Use 1s as the base delay (which leads to simpler computations)

* Acknowledge that with very large indexes we still need to produce
reasonable positive values, while the current algorithm breaks for
indexes large than `63`

* Acknowledge that, after incrementing exponentially for a while, it
makes sense to continue in a flat fashion, where we increment linearly,
while the current algorithm was aiming to always return 30s, which means
several attempts would actually run in parallel

* Acknowledge that we should use the same zero for all timings rather
than having a goroutine dependent zero

* Acknowledge that for now we don't need to mock `time.Now`

Part of https://github.com/ooni/probe/issues/2531

Run Details

22 of 22 new or added lines in 4 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

23699 of 29041 relevant lines covered (81.61%)

34.19 hits per line