MITLibraries / carbon / 6304464758

94%

push

github

In 924 fix ftp file transfer method (#114)

* IN-924 Investigate error with FTP file transfer

Why these changes are being introduced:
* The ftplib.storbinary method throws errors that suggest file
transfer has failed even when the Carbon run successfully uploads
an XML file to the Elements FTP server.

For the 'people' feed, it would log:
ftplib.error_temp: 425 Error while transfering data: ECONNABORTED - Connection aborted

For the 'articles' feed, it would log:
TimeoutError: The read operation timed out

These changes introduce cleaner error handling that avoid the error for
the 'people' feed and except' timeout errors that do not actually seem to
have a negative impact.

How this addresses that need:
* Remove custom storbinary method to resolve errors for 'people' feed
* Add try-except-finally code block to cleanly handle timeout errors for 'articles' feed
* Update README with instructions for downloading files

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-924

10 of 10 new or added lines in 3 files covered. (100.0%)

307 of 320 relevant lines covered (95.94%)

0.96 hits per line