ooni / probe-cli / 6271501372

82%

master: 84%

Build Type

Pull #1293

github

Committed by bassosimone

Commit Message

refactor(enginenetx): rename HTTPTransport to Network

The HTTPTransport model only offers a CloseIdleConnections callback, which
semantics is obviously that of closing idle connections (unsurprisingly).

However, the struct I am slowly building inside the enginenetx package soon will
need to write back statistics to disk using a key-value store.

I don't think we should overload the CloseIdleConnections semantics to do this
job, since the resulting code would be quite surprising.

Therefore, I have decided to rename HTTPTransport to Network and make it
represent all the network abstractions required by the OONI engine.

In time, I will move extra functionality in there. For now, let us be happy
that we can easily define a Close method (currently empty) for this type
having the usual io.Closer semantics, i.e., that any resource opened by the
type itself is released when calling this method.

This diff does the following:

- it renames the files;

- the type;

- the tests;

- it introduces an empty Close method;

- it adapts users of this code to use the new semantics;

- it introduces an model.KeyValueStore argument for the Network constructor
which we're going to use soon to persist statistics.

Part of https://github.com/ooni/probe/issues/2531

Pull Request Pull Request #1293: refactor(enginenetx): rename HTTPTransport to Network

Run Details

27 of 35 new or added lines in 3 files covered. (77.14%)

1 existing line in 1 file now uncovered.

23469 of 28804 relevant lines covered (81.48%)

29.4 hits per line