ooni / probe-cli / 6261510340

72%

push

github

refactor(enginenetx): introduce stats and make tactic a struct (#1291)

This diff refactors the code to introduce a stats interface and to make
the tactic a struct ~without methods attached.

We transform the tactic into a struct because we're planning on storing
the tactics on disk and loading them.

We need stats to track what is working and choose which is the best
tactic that we should employ.

In light of these two needs, it makes sense to transfer the reporting
methods that previously were part of the tactic interface to stats.

With this diff, we temporarily lost the possibility of choosing which
handshaker to use, which was not implemented anyway and needs some more
work to reason about how we'd store this information on disk.

Part of https://github.com/ooni/probe/issues/2531

41 of 41 new or added lines in 2 files covered. (100.0%)

23456 of 28784 relevant lines covered (81.49%)

26.66 hits per line