skeema / skeema / 6238577453

92%

push

github

diff/push: require --allow-unsafe in 3 more edge cases

This commit adjusts the behavior of `skeema diff` and `skeema push` to
consider 3 additional column modification situations to be unsafe, requiring
the use of either --allow-unsafe or --safe-below-size to proceed:

* Changing the collation of a column if that column appears in the primary
  key, or in at least one unique index: the collation change can potentially
  affect the equality operation in the uniqueness constraint, causing the
  operation to eventually fail with a duplicate key error. Better to catch
  this upfront immediately.

* Adding, removing, or changing the SRID of a spatial column in MySQL 8+:
  adding or changing the SRID effectively restricts what values may be
  present in the column (potentially conflicting with existing data);
  removing the SRID prevents the column from being usable in a spatial index.

* Converting the column type between TIME and TIMESTAMP: surprisingly the
  database server doesn't prevent this, even with a strict sql_mode in place.
  Converting from TIMESTAMP to TIME is lossy (the date portion of existing
  data is lost), while converting from TIME to TIMESTAMP is corruptive (the
  current date at the time of the operation is applied to all existing data).

58 of 58 new or added lines in 3 files covered. (100.0%)

9402 of 10085 relevant lines covered (93.23%)

1.11 hits per line