mozilla / mozilla_ci_tools / 1340

49%

push

travis-ci

Bug 1274507 - mozci believes certain pgo builders are invalid (#476)

We've recently made some changes to get_buildername_metadata() to
consider 'pgo' buildes. Unfortunately, I believe somewhat is producing
certain pgo builders to be considered invalid.

This change attempts to make get_buildername_metadata() easier to
understand. It also makes some tests follow py.test syntax plus disable
the test for building graphs. To be enabled in a follow up.

An easy test was to run this command:
```python
import logging

from mozci.mozci import valid_builder
from mozci.utils.log_util import setup_logging

setup_logging(logging.DEBUG)

valid_builder('Windows XP 32-bit mozilla-inbound pgo test mochitest-browser-chrome-1')
```

[1]
https://github.com/mozilla/mozilla_ci_tools/commit/593c6290c#diff-080760856cfeb3690166d07dd9636fdfL266

29 of 29 new or added lines in 2 files covered. (100.0%)

704 of 1538 relevant lines covered (45.77%)

0.46 hits per line