ooni / probe-cli / 6208315114

84%

Build Type

push

github

Committed by web-flow

Commit Message

feat: support for testing socks5 clients (#1280)

This diff imports a fork of github.com/armon/go-socks5 that has been
adapted to use netem and simplified to suit our testing needs.

With this functionality in tree, we can start thinking about writing
better netem based tests for the ooniprobe bootstrap.

The overall idea is to be well positioned to improve the bootstrap and
introduce dynamic support for beacons.

While there, discover that we were using `log.SetLevel(log.DebugLevel)`
in a racy way in tests, so remove all the instances of this call from
tests given that we can always add it when needed and we don't want to
keep commented out code as a general policy anyway.

Reference issue: https://github.com/ooni/probe/issues/2531

Run Details

345 of 372 new or added lines in 6 files covered. (92.74%)

8 existing lines in 3 files now uncovered.

23064 of 28386 relevant lines covered (81.25%)

24.88 hits per line