sandialabs / pyttb / 6208235918

99%

push

github

Default behavior of divmod() is different from MATLAB mod(), on which… (#242)

* Default behavior of divmod() is different from MATLAB mod(), on which… (#237)

* Default behavior of divmod() is different from MATLAB mod(), on which the original logic was based. The prior logic threw a ZeroDivisionError if printitn == 0. Instead, this fix avoids this error by testing that printitn > 0. Tests added for various values of printitn.

* Update tests/test_cp_als.py

Co-authored-by: Nick <24689722+ntjohnson1@users.noreply.github.com>

* Update tests/test_cp_als.py

Co-authored-by: Nick <24689722+ntjohnson1@users.noreply.github.com>

* Applying Nick's suggesetions to remove mark, change maxiters to save CPU cycles. Also removing output since nothing is actually checked.

* Removes mark

* Closes #235
---------

Co-authored-by: Jeremy Myers <jermyer@sandia.gov>
Co-authored-by: Nick <24689722+ntjohnson1@users.noreply.github.com>

* black: fixing black formatting

---------

Co-authored-by: Jeremy Myers <jmmyers01@wm.edu>
Co-authored-by: Jeremy Myers <jermyer@sandia.gov>
Co-authored-by: Nick <24689722+ntjohnson1@users.noreply.github.com>

1 of 1 new or added line in 1 file covered. (100.0%)

4484 of 4502 relevant lines covered (99.6%)

3.98 hits per line