ooni / probe-cli / 6199871493

84%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup: use testingx.NewHTTPProxyHandler as proxy (#1277)

This diff replaces `testingx.HTTPHandlerProxy` with
`testingx.NewHTTPProxyHandler` as the proxy used for implementing netemx
scenarios and removes `testingx.HTTPHandlerProxy`.

We introduced `testingx.NewHTTPProxyHandler` in
https://github.com/ooni/probe-cli/pull/1274. It is a more comprehensive
proxy because it supports both proxying via HTTP header and CONNECT
proxying.

While there, emit more clear debug messages during the TLS handshake.

While there, fix how we're skipping tests in `testingx` and
`testingproxy` because otherwise we end up skipping the netem tests that
we should not be skipping. (Noticed of this because the coverage
dropped!)

Reference issue: https://github.com/ooni/probe/issues/2531

Overall objective: good testing for proxying for when we introduce
beacons.

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

5 existing lines in 1 file now uncovered.

22707 of 28010 relevant lines covered (81.07%)

37.16 hits per line