6192324982
91%
master: 71%

Ran 15 Sep 2023 12:43AM UTC

Jobs 1

Files 61

Run time 2s

Badge

Embed ▾

Committed 15 Sep 2023 12:20AM UTC coverage: 90.861%. Remained the same

Build # 6192324982

Build Type

Pull #526

github

Committed by

peterstace

Commit Message

Don't validate results from GEOS

Recent versions of GEOS use OverlayNG (NG stands for New Generation) for
set operations between geometries (Intersection, Union, etc.). With the
introduction of OverlayNG, invalid geometries are no longer frequently
produced by GEOS. They are either non-existent, or very rare.

Before this change, the `simplefeatures` GEOS wrapper validates results
from GEOS.

This feels like a misalignment:

- Validation isn't free, so validating GEOS results seems like the wrong
  default.

- The GEOS wrapper is doing more than strictly wrapping the GEOS library
  (it is also validating the result). This blurs the lines between what
  simplefeatures is doing and what GEOS is doing.

This change removes that validation. Users can of course still validate
manually by calling the `Validate` method on the result.

Pull Request Pull Request #526: Don't validate results from GEOS

Run Details

7735 of 8513 relevant lines covered (90.86%)

31935.75 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	6192324982.1	15 Sep 2023 12:43AM UTC	0	90.86	GitHub Action Run

Source Files on build 6192324982

Detailed source file information is not available for this build.

peterstace / simplefeatures / 6192324982
91%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6192324982

peterstace / simplefeatures / 6192324982 91% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6192324982

peterstace / simplefeatures / 6192324982
91%
master: 71%

README BADGES
x