Gallopsled / pwntools / 6191812782

19%

push

github-actions

Allow empty argv in ssh.process() (#2217)  (#2234)

* Fix bug at ssh.py:process() - empty argv[0] Error

Before this, process.py relied on `os.execve` which disallows an empty
argv or argv[0] == "".
This commit replaces `os.execve` with  `ctypes.CDLL(None).execve` to
call the C-Library function directly which allows an empty argv.

* Add #2225 to stable changelog

* Better ctypes syntax

* Add error message if cytpes.execve fails.

* Updata CHANGELOG.md

* ssh.py: python2 compatibility for os.environb

* Add check that "=" not in misc.normalize_argv_env

This check checks prevents the use of "=" in the
key of an environment variable, which is generally
impossible.

* ssh.process: Seperate cases for empty argv[0]

This commit seperates the cases for an empty argv[0]
from normal cases.

* ssh.py delete leftover comment

---------

Co-authored-by: Youheng Lü <90871590+Youheng-Lue@users.noreply.github.com>
Co-authored-by: Arusekk <arek_koz@o2.pl>
Co-authored-by: peace-maker <peace-maker@wcfan.de>

4568 of 7244 branches covered (0.0%)

5 of 5 new or added lines in 2 files covered. (100.0%)

12780 of 17189 relevant lines covered (74.35%)

0.74 hits per line