tari-project / tari / 6171022314

61%

push

github

feat!: improve block add where many orphan chain tips existed (#5763)

Description
---
Improved block add due to previous inefficient retrieval of the
strongest orphan chain header.

The previous algo retrieved all orphan blocks for all orphan chain tips,
without evaluating the total accumulated difficulty. This PR added total
accumulated difficulty to the orphan chain tips db so that efficient
retrieval of only the strongest orphan chain headers can be done.

Block add times improved drastically by multiple orders of magnitude in
the case where many orphan chain tips existed as only one or very
seldomly two orphan chain tips would have the same total accumulated
difficulty, thereby minimizing the retrieval of orphan blocks to enable
the construction of orphan chain headers.

These symptoms were aggravated when candidate blocks were solved quicker
than the base node could process them, resulting in a negative spiral of
adding even more orphan chain tips when corresponding slowing down of
blocks that were added to the blockchain.

Motivation and Context
---
See above

How Has This Been Tested?
---
New unit test added
System level testing on Igor

What process can a PR reviewer use to test or verify this change?
---
Code walk through and system level testing

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [] None
- [x] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
BREAKING CHANGE: The blockchain database should be deleted and then
re-synced from the network.

188 of 188 new or added lines in 6 files covered. (100.0%)

71744 of 95359 relevant lines covered (75.24%)

189586.78 hits per line