ooni / probe-cli / 6159453164

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(MeasuringNetwork): define dialers without resolver (#1259)

I initially planned on defining only the dialers with resolver and
explicitly passing `&NullResolver{}` to them.

But I have just realized that, instead, defining the dialers without
resolvers (which is what measurexlite needs anyway) will allow me to
rewrite the without-resolver case to be very simple and completely
ignore resolvers.

Once I have done this rewrite, we can keep the existing implementation
for legacy code, but we can also have:

1. the above-mentioned simple dialing implementation without resolvers
that fullfills measurexlite needs;

2. another implementation tailored to the needs of beacons.

So, voila, I think I now have a reasonable way forward to introduce
beacons support in netxlite.

Part of https://github.com/ooni/probe/issues/2531

Run Details

14 of 14 new or added lines in 3 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

22365 of 27601 relevant lines covered (81.03%)

30.86 hits per line