• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ooni / probe-cli / 6159453164
72%

Build:
DEFAULT BRANCH: master
Ran 12 Sep 2023 12:36PM UTC
Jobs 1
Files 480
Run time 18s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Sep 2023 12:31PM UTC coverage: 81.03% (+0.01%) from 81.017%
6159453164

push

github

web-flow
refactor(MeasuringNetwork): define dialers without resolver (#1259)

I initially planned on defining only the dialers with resolver and
explicitly passing `&NullResolver{}` to them.

But I have just realized that, instead, defining the dialers without
resolvers (which is what measurexlite needs anyway) will allow me to
rewrite the without-resolver case to be very simple and completely
ignore resolvers.

Once I have done this rewrite, we can keep the existing implementation
for legacy code, but we can also have:

1. the above-mentioned simple dialing implementation without resolvers
that fullfills measurexlite needs;

2. another implementation tailored to the needs of beacons.

So, voila, I think I now have a reasonable way forward to introduce
beacons support in netxlite.

Part of https://github.com/ooni/probe/issues/2531

14 of 14 new or added lines in 3 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

22365 of 27601 relevant lines covered (81.03%)

30.86 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0 - 6159453164.1 12 Sep 2023 12:36PM UTC 0
81.03
GitHub Action Run
Source Files on build 6159453164
Detailed source file information is not available for this build.
  • Back to Repo
  • a76ac682 on github
  • Prev Build on master (#6158945626)
  • Next Build on master (#6160369057)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc