• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ooni / probe-cli / 6155453689
72%

Build:
DEFAULT BRANCH: master
Ran 12 Sep 2023 05:59AM UTC
Jobs 1
Files 477
Run time 7s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Sep 2023 05:53AM UTC coverage: 80.991% (-0.02%) from 81.007%
6155453689

push

github

web-flow
refactor(netxlite): use *Netx for the system resolver (#1248)

This diff modifies how we construct netxlite's system resolver such that
public functions use the *Netx equivalents.

While there, recognize that there wasn't enough testing for the optional
wrappers provided by `model.DNSTransportWrapper` and that we are not
using this functionality. So, rather than writing new tests for this
functionality, we can actually just drop it and simplify the codebase.

While there, recognize that `netxlite.WrapDNSTransport` could easily
become private.

While there, recognize that `./legacy/netx` needs lots of public
function being exported by `netxlite` but we don't need to expose that
many implementation details to new code that will be using `*Netx`. So,
make sure all the new methods we create for `*Netx` are actually private
methods. (Ideally, the API surface of `netxlite` should be smaller; we
would not be able to get there for quite some time, but we can at least
avoid increasing the API surface.)

The general idea for which I am pushing here is to have additional
clarity about dependencies, to better analyze the requirements of non
measuring code for https://github.com/ooni/probe/issues/2531.

33 of 35 new or added lines in 6 files covered. (94.29%)

2 existing lines in 1 file now uncovered.

22317 of 27555 relevant lines covered (80.99%)

36.16 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0 - 6155453689.1 12 Sep 2023 05:59AM UTC 0
80.99
GitHub Action Run
Source Files on build 6155453689
Detailed source file information is not available for this build.
  • Back to Repo
  • 7224984b on github
  • Prev Build on master (#6148419366)
  • Next Build on master (#6155771266)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc