ooni / probe-cli / 6124747788

72%

push

github

probe-cli: Update to quic-go v0.37.3  (#1161)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)

- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/2492

## Description

This diff updates our QUIC code, mainly in netxlite, to quic-go v0.37.1,
including the new API introduced in v0.35.0.

The migration has been done according to https://github.com/ooni/probe/issues/2492.

Major changes: 

* Replaced call to `quic.DialEarlyContext` with call to `quic.DialEarly` (netxlite/quic.go).

* Removed now unnecessary address string in `DialEarly` calls (netxlite/quic.go).

* Replaced `quic.Listener` with `*quic.Listener` (simplequicping_test.go).

* Adapted signature of `HandshakeComplete` such that it returns a
channel rather than a context (quic code in netxlite, measurex, mocks).

* Renamed `QUICListener` to `UDPListener`.

* `quic.ConnectionState.TLS` points directly to a `tls.ConnectionState`
instead of pointing to a `qtls.ConnectionState` instance. Background:
Starting with Go 1.21, quic-go will use the QUIC support provided by the
standard library's TLS implementation. Thus, quic-go will no longer fork
crypto/tls anymore.

* changed signature of `quic.Connection`'s `ReceiveMessage` method

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>

40 of 48 new or added lines in 12 files covered. (83.33%)

22332 of 27563 relevant lines covered (81.02%)

27.8 hits per line