• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 6114685855
69%

Build:
DEFAULT BRANCH: main
Ran 07 Sep 2023 08:58PM UTC
Jobs 2
Files 532
Run time 18s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Sep 2023 08:55PM UTC coverage: 69.323% (-0.01%) from 69.334%
6114685855

push

github

web-flow
Focus Fixes for our Mobile Expression Keypad and MathInput  (#701)

## Summary:
Ensured that the input span is focusable via tab navigation and that we cannot accidentally create a callback loop with our updated focus. 

I also implemented a couple of fixes to our full math input story so that it doesn't error when trying to callback, and blurs the input upon closing the keypad.

A separate fix will be implemented in WebApp that ensures that closing the keypad in an exercise moves the focus to the "Check Answer" button. It will be attached to the same ticket number (LC-1193) as it is directly related to the issue.

 ## Video:
https://github.com/Khan/perseus/assets/12463099/b5b418f6-64b6-41e5-9d6d-1a7c13410a29


Issue: LC-1193

## Test plan:
make tesc

Author: SonicScrewdriver

Reviewers: SonicScrewdriver, handeyeco, jeremywiebe

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/701

7650 of 16642 branches covered (0.0%)

Branch coverage included in aggregate %.

4 of 22 new or added lines in 3 files covered. (18.18%)

1 existing line in 1 file now uncovered.

71699 of 97820 relevant lines covered (73.3%)

709.96 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
5
47.26
-2.03% packages/math-input/src/components/keypad/mobile-keypad.tsx
6
62.83
-0.42% packages/math-input/src/components/input/math-input.tsx
7
0.0
0.0% packages/math-input/src/full-math-input.stories.tsx

Uncovered Existing Lines

Lines Coverage ∆ File
1
62.83
-0.42% packages/math-input/src/components/input/math-input.tsx
Subprojects
ID Flag name Job ID Ran Files Coverage
1 jest 6114685855.1 07 Sep 2023 09:06PM UTC 527
63.31
GitHub Action Run
2 cypress 6114685855.2 07 Sep 2023 08:58PM UTC 369
26.11
GitHub Action Run
Source Files on build 6114685855
  • Tree
  • List 532
  • Changed 12
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • fa1bb6b4 on github
  • Prev Build on main (#6114169175)
  • Next Build on main (#6148771706)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc