Khan / perseus / 6114685855

69%

Build Type

push

github

Committed by web-flow

Commit Message

Focus Fixes for our Mobile Expression Keypad and MathInput  (#701)

## Summary:
Ensured that the input span is focusable via tab navigation and that we cannot accidentally create a callback loop with our updated focus. 

I also implemented a couple of fixes to our full math input story so that it doesn't error when trying to callback, and blurs the input upon closing the keypad.

A separate fix will be implemented in WebApp that ensures that closing the keypad in an exercise moves the focus to the "Check Answer" button. It will be attached to the same ticket number (LC-1193) as it is directly related to the issue.

 ## Video:
https://github.com/Khan/perseus/assets/12463099/b5b418f6-64b6-41e5-9d6d-1a7c13410a29


Issue: LC-1193

## Test plan:
make tesc

Author: SonicScrewdriver

Reviewers: SonicScrewdriver, handeyeco, jeremywiebe

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/701

Run Details

7650 of 16642 branches covered (0.0%)

Branch coverage included in aggregate %.

4 of 22 new or added lines in 3 files covered. (18.18%)

1 existing line in 1 file now uncovered.

71699 of 97820 relevant lines covered (73.3%)

709.96 hits per line