ooni / probe-cli / 6097620701

84%

Build Type

push

github

Committed by web-flow

Commit Message

cleanup: remove jafar and the previous QA framework (#1244)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

## Description

This is the final act of the quest to replace Jafar. Let's remove Jafar
itself and the QA framework using it. We now have a much better QA
framework, that runs for each commit, is faster, and allows to better
emulate censorship cases.

While working on the removal, I noticed some tutorials depended on a
limited set of Jafar functionality, namely the possibility of provoking
simple censorship conditions. So, I refactored the previous code for
managing iptables on Linux used by Jafar to produce a much slimmer,
fully unit tested tool implementing a subset of the original CLI.

By implementing this change, we make sure that we still have simple ways
for people to learn while reading tutorials.

What remains to be done at this point is to update existing issues,
close done issues, and generally make sure we explain clearly what we
achieved by working on this quest, and what new features are now
available.

Run Details

120 of 120 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

22330 of 27564 relevant lines covered (81.01%)

24.76 hits per line