• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 6088045513
69%

Build:
DEFAULT BRANCH: main
Ran 05 Sep 2023 05:54PM UTC
Jobs 2
Files 532
Run time 16s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Sep 2023 05:51PM UTC coverage: 69.353% (-0.006%) from 69.359%
6088045513

push

github

web-flow
Refresh design of image caption (#693)

## Summary:

<img width="755" alt="image" src="https://github.com/Khan/perseus/assets/18454/32d18329-541d-46e7-aebc-3431f3fe2675">

Refreshes the design of the image widget's caption so that:
- It doesn't overflow the bounds of the image
- It has a slightly different visual treatment
- Improves accessibility by using figure/figcaption

Issue: https://khanacademy.atlassian.net/browse/LC-1084

## Test plan:
- run the storybook
- There should be a new new question for the image widget
- Look at the caption on Question 2
- **It should look ok**

Author: nixterrimus

Reviewers: handeyeco, nixterrimus

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald, ✅ Check for .changeset file (ubuntu-latest, 16.x)

Pull Request URL: https://github.com/Khan/perseus/pull/693

7649 of 16637 branches covered (0.0%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

71701 of 97778 relevant lines covered (73.33%)

710.31 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
1 cypress 6088045513.1 05 Sep 2023 05:54PM UTC 369
26.12
GitHub Action Run
2 jest 6088045513.2 05 Sep 2023 06:04PM UTC 527
63.34
GitHub Action Run
Source Files on build 6088045513
  • Tree
  • List 532
  • Changed 21
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • 100fb7e5 on github
  • Prev Build on main (#6030611284)
  • Next Build on main (#6089317174)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc