ooni / probe-cli / 6085538263

84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: merge filtering's HTTP code with testingx (#1235)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

## Description

This diff merges internal/filtering's code with testingx. While doing
this, we refactor the code to (1) be a drop-in replacement for the
net/http/httptest package and (2) use interfaces rather than string
values to select the proper behavior, which makes the code more
composable than it was before.

The overall objective of this effort is to consolidate filtering into
testingx such that we can later merge the proxy capabilities implemented
by Jafar into the testingx package, which is a stepping stone for
ditching Jafar.

Run Details

102 of 102 new or added lines in 4 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

21919 of 27467 relevant lines covered (79.8%)

38.62 hits per line