ooni / probe-cli / 6078273599

80%

master: 84%

Build Type

Pull #1228

github

Committed by bassosimone

Commit Message

fix(netemx): address issues with quic-go/quic-go

This diff fixes https://github.com/ooni/probe/issues/2527.

The comment I originally wrote in the code to explain the issue read:

> I am wondering whether I am not fully understanding how quic-go/quic-go works.

It turns out this comment was true. I was assuming http3.Server was closing
the listener, however, that was not the case.

I noticed this issue when reading again netemx/qaenv.go.

So, it all boiled down to PEBCAK 😬.

Pull Request Pull Request #1228: fix(netemx): address issues with quic-go/quic-go

Run Details

11 of 12 new or added lines in 3 files covered. (91.67%)

1 existing line in 1 file now uncovered.

21957 of 27480 relevant lines covered (79.9%)

24.5 hits per line