ooni / probe-cli / 6077814244

72%

Build Type

push

github

Committed by web-flow

Commit Message

feat(netemx): implement NetStackServerFactory for DNS-over-UDP (#1225)

This diff moves forward the work we're doing to try to unify the way in
which all the possible servers in netemx are constructed.

The general idea is to enable configuring every kind of server using the
QAEnvOptionNetStack option.

To this end, we need to implement NetStackServerFactory.

In this diff, in particular, we're implementing a NetStackServerFactory
for constructing DNS-over-UDP servers. These servers would use:

1. the OtherResolversConfig for lookups (which makes sense because the
[MustNewQAEnv] internally constructs the ISP resolver);

2. the logger configured for the QAEnv.

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

Run Details

54 of 54 new or added lines in 6 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

21928 of 27456 relevant lines covered (79.87%)

25.61 hits per line