ooni / probe-cli / 6076977401

84%

push

github

feat(netemx): HTTPS server implementing NetStackServerFactory (#1223)

This diff continues improving and refactoring netemx with the objective
of unifying how we create all kind of servers.

Here, specifically, we modify the HTTP server implementing
NetStackServerFactory implemented in the previous commit and obtain an
HTTPS server honouring NetStackServerFactory.

Crucially, this diff also adds support for overriding the TLS config
passed to the server, which enables us to test for expired certificates,
self-signed certificates, and so forth.

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
https://github.com/ooni/probe/issues/1803
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

57 of 57 new or added lines in 1 file covered. (100.0%)

21823 of 27350 relevant lines covered (79.79%)

31.91 hits per line