ooni / probe-cli / 6076514949

84%

push

github

refactor(netemx): move towards unified factory/server (#1221)

This diff starts refactoring netemx such that any kind of service we
want to create for a given IP address uses the same interface, which is
a generic factory to create a generic server working depending on a
netstack.

The overall objective here is to enable the same IP address to serve
DNS, HTTP/HTTPS/HTTP3, and possibly arbitrary other services. Currently,
we can only choose one of these services per IP address. This
limitation, for example, makes it impossible to have 8.8.8.8 handle both
Do53 and DoH.

I will move towards this objective incrementally. This diff just
refactors the way in which we manage the echo server to follow a model
where there is a factory for creating a server, which is what HTTP code
is using.

Once this diff lands, I will refactor HTTP and DNS to follow this model.
And, after that, I will try to allow multiple factories for each IP
addr.

Reference issue: https://github.com/ooni/probe/issues/1803

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request: see above
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

40 of 40 new or added lines in 2 files covered. (100.0%)

21716 of 27239 relevant lines covered (79.72%)

32.45 hits per line