ooni / probe-cli / 6073837589

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix: avoid using 130.192.91.x for most netemx addresses (#1219)

As we learned in https://github.com/ooni/probe-cli/pull/1216, using the
130.192.91.x namespace for every IP address in netemx breaks mapping
domain names to IP addresess in Web Connectivity. No IP address would
ever, in fact, be inconsistent, because they all belong to AS137.

Initially, I thought about overriding the code that maps IP addresses to
ASNs, to provide a custom implementation. But then I realized it was a
more thorough test to use the default implementation (relying on
maxminddb files) and using the correct IP addresses in the correct
address space.

My original thought for using 130.192.91.x addresses was that they were
not the right addresses for the domains we're testing, thus, in the
event in which netem was not WAI, all tests would have failed. However,
we have many tests checking that netem is WAI already, so probably I was
being excessively paranoid.

As a result, this patch modifies the code to use the correct addresses.
We're still using some 130.192.91.x addresses where it makes sense to do
so (user's IP address and default user's resolver).

Part of https://github.com/ooni/probe/issues/1803.

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request: see above
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: N/A
- [x] if you changed code inside an experiment, make sure you bump its
version number: N/A

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

9 existing lines in 1 file now uncovered.

21627 of 27172 relevant lines covered (79.59%)

23.49 hits per line