neo-project / neo / 6070350868

77%

push

github

Payloads: implement Conflicts attribute (#2818)

* Payloads: implement Conflicts attribute

Closes #1991.

* Update src/Neo/Ledger/MemoryPool.cs

* Fix conflicting tx fees accounting

Fix the comment https://github.com/neo-project/neo/pull/2818#discussion_r1130790669.

* Reformat code and improve variables naming

Fix Vitor's comments.

* Make comments more clear and adjust variables naming

Fix Owen's feedback.

* Fix Conflicts attribute verification

Consider the case when transaction B has the hash of transaction A
in the Conflicts attribute and transaction B is on-chain. Let the
transaction C has the hash of transaction A in the Conflicts attribute.
Then transaction C still should be able to pass verification and should
be accepted to the subsequent block, because transaction A isn't on chain
and transaction A will never be accepted.

Thanks to Owen for testing, this case is described at the
https://github.com/neo-project/neo/pull/2818#pullrequestreview-1443230800.
The expected behaviour in the described case is that TXID-D and TXID-E will
be successfully accepted to the mempool and to chain, because the conflicting
TXID-A is not on chain (and it's OK that the hash of TXID-A is on-chain as
the conflicting hash).

* Fix formatting, comments and add a testcase for conflicting mempool txs

* Add one more testcase for conflicting transactions

Testcase provided by Vitor in https://github.com/neo-project/neo/pull/2818#discussion_r1209313799.

* Implement economic adjustments for Conflicts attribute

Transaction that conflicts with mempooled transactions have to pay
larger network fee than the sum of all conflicting transactions in
the pool that have the same sender as the newcomer.

Port the https://github.com/nspcc-dev/neo-go/pull/3031.

* Remove Trimmed value

* Check signers of on-chained conflict during new tx verification

Fix the problem described in
https://github.com/neo-project/neo/pull/2818#pullrequestreview-1526521347.

During new transactio... (continued)

2999 of 4848 branches covered (0.0%)

Branch coverage included in aggregate %.

178 of 178 new or added lines in 9 files covered. (100.0%)

10114 of 13333 relevant lines covered (75.86%)

18171.1 hits per line