IntelPython / dpctl / 6002187169

86%

push

github

Fixes boolean indexing for strided masks (#1370)

* Corrected boolean indexing cumsum
- The cumulative sum was being calculated incorrectly -- the offset from stride simplification was unused and the result was incorrect for some cases with non-C-contiguous strides
- To fix this, new functions ``compact_iteration_space`` and complementary function ``compact_iteration`` have been implemented

* Add a test for nonzero where dimension compacting occurs

* Added tests for the corrected behavior of boolean indexing and nonzero

* Removed dead branch in py_mask_positions

Compacting strides can reduce dimensionality of the array, but it can not
turn an input that is not already C-contiguous into a C-contiguous one.

Hence the branch checking if the input became C-contiguous after compacting
is effectively dead.

* Added docstring for compact_iteration

---------

Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>

2345 of 2772 branches covered (0.0%)

Branch coverage included in aggregate %.

8491 of 9883 relevant lines covered (85.92%)

7942.97 hits per line