basilisp-lang / basilisp / 6000632053

99%

push

github

Fix issue with `with` failing with traceback error. (#715)

Hi,

could you please fix for `with` to not fail with traceback error when an
exception is thrown. It fixes #714 .

It seems that the `with` macro expected the `__traceback__` field of an
exception to be a method, but it is rather a __field__
https://docs.python.org/3/library/traceback.html
> The module uses traceback objects — these are objects of type
[types.TracebackType](https://docs.python.org/3/library/types.html#types.TracebackType),
which are assigned to the __traceback__ field of
[BaseException](https://docs.python.org/3/library/exceptions.html#BaseException)
instances.

For some reason this issue does not manifest with `python/open`
resources, as if the `__enter__` magic method is not hit (or perhaps it
is lazy gc and it will eventually happen).

I've added a test for the same.

Thanks,

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1641 of 1643 branches covered (0.0%)

Branch coverage included in aggregate %.

7720 of 7801 relevant lines covered (98.96%)

0.99 hits per line