parroty / exvcr / d1c17651682c7457f5393c901b62f170240d73af

92%

push

github

Normalizes request body and URL by parsing params to a list and sorting (#211)

* Normalizes request body by parsing as params, then converting to a list

Before this change, if the request body was a list of params that were
in a different order than the params in the cassette, the request body
match would fail.

As of OTP 26, map key order is not guaranteed, so request bodies that
are created using maps can fail to match since the order of their keys
is not idempotent.

These changes convert the request body to a list of params and sort it
before comparing it to the request body in the cassette. This ensures
cassettes will be matched as long as their request bodies contain the
same set of key-value pairs as the incoming request body.

* Normalizes url by parsing params, converting to a list, and sorting

Before this change, if the url query params were in a different order
than the url params in the cassette, the request body match would fail.

As of OTP 26, map key order is not guaranteed, so url params that are
created using maps can fail to match since the order of their keys is
not idempotent.

These changes convert the url params to a list and sort it before
comparing it to the url in the cassette. This ensures cassettes will be
matched as long as their url params contain the same set of key-value
pairs as the incoming url params (and the rest of the url matches too).

9 of 9 new or added lines in 1 file covered. (100.0%)

599 of 648 relevant lines covered (92.44%)

1116.2 hits per line