Khan / perseus / 5981712826

69%

Build Type

push

github

Committed by web-flow

Commit Message

[🔥AUDIT🔥] Revert type changes made in #694 (#695)

🖍 _This is an audit!_ 🖍

## Summary:

Mea culpa.

In #694 I snuck in a seemingly tiny improvement to our Perseus types: switching the `item` prop on ServerItemRenderer to be a true `PerseusItem` (which it should be). 

However, in consuming apps there are many places where we pass in data that doesn't quite conform to this type. Many of these instances are in unit test data. 

Given that we have a somewhat urgent fix waiting on `main`, I'm reverting these small type changes and we can get them implemented in the future when we aren't trying to ship a bugfix as well. 

Issue: LC-1180

## Test plan:

Once integrated into our client apps, `yarn typecheck` should pass without issues.

Author: jeremywiebe

Auditors: #perseus

Required Reviewers:

Approved By:

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/695

Run Details

7647 of 16634 branches covered (0.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

71723 of 97793 relevant lines covered (73.34%)

710.25 hits per line