• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

smartsheet / smartsheet-java-sdk / #44
60%

Build:
DEFAULT BRANCH: mainline
Ran 25 Aug 2023 05:41PM UTC
Jobs 1
Files 357
Run time 28s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

25 Aug 2023 05:39PM UTC coverage: 50.55% (+0.1%) from 50.427%
#44

push

github-actions

web-flow
Fix remaining Checkstyle violations and Enable Checkstyle (#58)

* Fix remaining Checkstyle violations and Enable Checkstyle

We are now down to `20` checkstyle violations in main and `0` violations in test.

The remaining 20 violations are not trivial to fix, so I've set checkstyle to allow those 20 violations to exist, but to fail the build if we ever exceed 20 violations. This should make the build fail if any new violations are added.

For tests, we do not allow _any_ violations. This means adding a single violation will fail the build. Once the 20 violations in main are cleaned up, we can make main and test have the same config.

Note: This MR also changes our PR pipeline to run `./gradlew clean build` instead of `./gradlew clean test`. The reason for this is that build runs all the tests and performs all the other checks (such as checkstyle), whereas `test` didn't run checkstyle and we wouldn't have noticed violations until we tried to deploy.

148 of 148 new or added lines in 24 files covered. (100.0%)

3448 of 6821 relevant lines covered (50.55%)

0.51 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
0.0% src/main/java/com/smartsheet/api/internal/json/CellLinkSerializer.java
1
0.0
0.0% src/main/java/com/smartsheet/api/internal/json/CellSerializer.java
1
1.52
0.0% src/main/java/com/smartsheet/api/internal/json/WidgetContentDeserializer.java
2
62.86
-2.77% src/main/java/com/smartsheet/api/SmartsheetBuilder.java
2
75.0
0.0% src/main/java/com/smartsheet/api/SmartsheetRestException.java
2
39.29
0.0% src/main/java/com/smartsheet/api/Trace.java
2
56.1
0.0% src/main/java/com/smartsheet/api/internal/json/ObjectValueDeserializer.java
3
0.0
0.0% src/main/java/com/smartsheet/api/internal/http/AndroidHttpClient.java
3
8.33
0.0% src/main/java/com/smartsheet/api/internal/json/RecipientDeserializer.java
3
0.0
0.0% src/main/java/com/smartsheet/api/models/enums/FolderCopyInclusion.java
3
0.0
0.0% src/main/java/com/smartsheet/api/models/enums/WorkspaceCopyInclusion.java
4
67.19
0.0% src/main/java/com/smartsheet/api/internal/http/DefaultHttpClient.java
4
61.9
2.81% src/main/java/com/smartsheet/api/internal/json/ErrorDeserializer.java
4
0.0
0.0% src/main/java/com/smartsheet/api/models/enums/SheetCopyInclusion.java
5
7.14
0.0% src/main/java/com/smartsheet/api/internal/json/HyperlinkSerializer.java
5
0.0
0.0% src/main/java/com/smartsheet/api/oauth/OAuthFlowBuilder.java
7
93.41
0.41% src/main/java/com/smartsheet/api/internal/http/RequestAndResponseData.java
15
0.0
0.0% src/main/java/com/smartsheet/api/internal/oauth/OAuthFlowImpl.java

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
0.0% src/main/java/com/smartsheet/api/internal/json/CellLinkSerializer.java
1
66.67
0.0% src/main/java/com/smartsheet/api/internal/json/CellSerializerModifier.java
1
39.29
0.0% src/main/java/com/smartsheet/api/Trace.java
2
61.9
2.81% src/main/java/com/smartsheet/api/internal/json/ErrorDeserializer.java
2
7.14
0.0% src/main/java/com/smartsheet/api/internal/json/HyperlinkSerializer.java
3
0.0
0.0% src/main/java/com/smartsheet/api/internal/oauth/OAuthFlowImpl.java
Jobs
ID Job ID Ran Files Coverage
1 #44.1 25 Aug 2023 05:41PM UTC 357
50.55
Source Files on build #44
  • Tree
  • List 357
  • Changed 88
  • Source Changed 0
  • Coverage Changed 88
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Build #44
  • d58f8001 on github
  • Prev Build on mainline
  • Next Build on mainline
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc