tarantool / tarantool / 5964520285

88%

push

github

box: fix memory leak on error_unpack_unsafe() failure

Memory is leaked in the following scenario:
- MP_ERROR_STACK with 2 errors is passed to error_unpack_unsafe():
  1. A correct MP_MAP with MP_ERROR_* fields;
  2. Something unexpected, e.g. MP_INT;
- This first call to mp_decode_error_one() allocates memory for the first
  error in error_build_xc() -> `new ClientError()`;
- The second call to mp_decode_error_one() returns NULL, and
  error_unpack_unsafe() returns NULL too. Memory from the previous step
  is leaked.

Closes #8921

NO_DOC=bugfix

63979 of 115674 branches covered (0.0%)

8 of 8 new or added lines in 1 file covered. (100.0%)

95740 of 111038 relevant lines covered (86.22%)

2654933.21 hits per line