tarantool / tarantool / 5962218466

88%

push

github

election: fix box.ctl.demote() nop in off-mode

box.ctl.demote() used not to do anything with election_mode='off'
if the synchro queue didn't belong to the caller in the same term
as the election state.

The reason could be that if the synchro queue term is "outdated",
there is no guarantee that some other instance doesn't own it in
the latest term right now.

The "problem" is that this could be workarounded easily by just
calling promote + demote together.

There isn't much sense in fixing it for the off-mode because the
only reasons off-mode exists are 1) for people who don't use
synchro at all, 2) who did use it and want to stop. Hence they
need demote just to disown the queue.

The patch "legalizes" the mentioned workaround by allowing to
perform demote in off-mode even if the synchro queue term is old.

Closes #6860

NO_DOC=bugfix

63879 of 115406 branches covered (55.35%)

18 of 18 new or added lines in 1 file covered. (100.0%)

95564 of 110718 relevant lines covered (86.31%)

2724834.86 hits per line