playwright-community / playwright-go / 5959564339

80%

Build Type

push

github

Committed by web-flow

Commit Message

Automatically generate Go interfaces code, etc. (#367)

BREAKING CHANGE: 
Due to the rewrite of the go code generation scripts, it brings the following **breaking** changes:

- Optimized generated comments. Links and **Deprecated** tags in Go doc comments now work.
  - May cause many **Deprecated** lint errors, please update the call or use `//nolint:staticcheck` to ignore.
- Added event interface methods. For example `Page.OnDialog()` etc.
- The signatures of some interface methods have changed, for example:
  - Unified optional parameter naming. For example, previously all `Click` used `PageClickOptions`, now
    ```go
    Locator.Click(options ...LocatorClickOptions)
    Page.Click(selector string, options ...PageClickOptions)
    Frame.Click(selector string, options ...FrameClickOptions)
    ```
  - Some parameters are generated as new types or names, e.g. `Page.AddInitScript(script Script)`
- Removed several methods that were not documented upstream. These methods can be safely converted to other existing methods.  For example
  - `Page.ExpectedDialog` can use `Page.OnDialog` instead.
  - All `xxxAssertions.NotTo...`, use `.Not().xxx` pls.

Run Details

602 of 919 new or added lines in 27 files covered. (65.51%)

5 existing lines in 3 files now uncovered.

5813 of 7676 relevant lines covered (75.73%)

3715.78 hits per line