ooni / probe-cli / 5953821243

84%

Build Type

push

github

Committed by web-flow

Commit Message

feat(netxlite): construct types with custom UnderlyingNetwork (#1197)

This diff introduces the netxlite.Netx type. This type depends on a
model.UnderlyingNetwork. When the underlying network is nil, using this
type is equivalent to using netxlite toplevel functions directly.

To simplify testing this diff, let's move the netem->netxlite
UnderlyingNetworkAdapter from netemx and let's use netem to write tests,
so we can have confidence specifically about the most common use case of
overriding the underlying network.

Originally part of https://github.com/ooni/probe-cli/pull/1185.

The reference issue is https://github.com/ooni/probe/issues/2461.

---------

Co-authored-by: kelmenhorst <k.elmenhorst@mailbox.org>

Run Details

54 of 54 new or added lines in 3 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

20746 of 26670 relevant lines covered (77.79%)

24.49 hits per line