angelolab / toffy / 5943435624

92%

push

github

Mass proficient extraction for NAS storage (#342)

* Initial commit of mass proficient extraction

* Add mass proficient MPH extraction

* Ensure bin_extraction also handles proficient metrics extraction

* Handle mass proficient and deficient bin file extraction separately (in case missing FOVs different for both)

* Add mass proficient MPH normalization generation to 4b notebook

* OCD comment change

* Ensure mass proficient panel passed to proficient extraction in 3b notebook

* Typo fix

* Ensure mass proficient directory actually gets created prior to extraction in notebook 3b

* Make comment about mass proficient extraction more clear

* Ensure pulse height generation doesn't attempt to read in proficient metric data

* Remove duplicate intermediate callback

* Typo in FOV callbacks

* Add flag to control proficient extraction or not

* Nuke proficient MPH extraction

* Timing tests for normalization

* Update pyproject.toml dependencies to be compatible with mibi-bin-tools and alpineer

* Standardize the deficient and proficient ranges based on agreed upon range values

* Delete timeit print statements for MPH

* Begin reducing test cases

* Document the start and stop offset params

* Update poetry lock file to ensure this actually installs

* Clarify comment about extraction ranges

* Fix another extraction window comment

* Make sure extract_prof is included as a param to watcher tests

* Add extract_prof param to inter_callback test

* Revert back to old deficient and proficient extraction ranges

* Pulse heights are not extracted for deficient and proficient data anymore

* Clarify comment

1319 of 1442 branches covered (91.47%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 3 files covered. (100.0%)

2549 of 2774 relevant lines covered (91.89%)

0.92 hits per line