bitcoindevkit / bdk / 5942119415

80%

master: 78%

push

github

Merge bitcoindevkit/bdk#1090: fix(electrum): Don't ignore multiple coinbase txs

<a class=hub.com/bitcoindevkit/bdk/commit/530ba36b07f2cddad90b844ef1a56cb27ee1cf74">530ba36b0<a href="https://github.com/bitcoindevkit/bdk/commit/e3ca356caec436520e0b433e081f3ff591c1d069"> ci: fix msrv dependency versions for reqest and h2 (Daniela Brozzoni)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/7a359d5eef66e60e0ab604fb0d043c2db260252d">7a359d5ee</a> fix(electrum): Don't ignore multiple coinbase txs (Daniela Brozzoni)

Pull request description:

  We would previously insert just one coinbase transaction in the database if we caught multiple in the same sync.
  When we sync with electrum, before committing to the database, we remove from the update conflicting transactions, using the `make_txs_consistent` function. This function considers two txs to be conflicting if they spend from the same outpoint - but every coinbase transaction spends from the same outpoint!
  Here we make sure to avoid filtering out coinbase transactions, by adding a check on the txid just before we do the filtering.

  Fixes #1051

  ### Changelog notice

  - Fix a bug when syncing coinbase utxos on electrum

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    tACK 530ba36b07f2cddad90b844ef1a56cb27ee1cf74

Tree-SHA512: ebbc6af86db345cc062ab4ff0d0cbeb72cb

10 of 10 new or added lines in 2 files covered. (100.0%)

14630 of 18343 relevant lines covered (79.76%)

9264.42 hits per line