• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

bhuga / promising-future / 25
100%

Build:
DEFAULT BRANCH: master
Ran 17 May 2016 02:56PM UTC
Jobs 4
Files 7
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
25

Pull #27

travis-ci

raxoft
Make force work in conditions for futures, not only promises.

The Future#__force__ should return the resulting value, not the promise. Otherwise things like
``` ruby
   puts "true" if future{ true }.force
   puts "false" if future{ false }.force
   puts "nil" if future{ nil }.force
```
do not work as expected (currently all evaluate to true). I believe it should work consistently with promises:
``` ruby
   puts "true" if promise{ true }.force
   puts "false" if promise{ false }.force
   puts "nil" if promise{ nil }.force
```
The change above should achieve this. However note it may change how the marshalling works with regard to futures, as the special marshalling handling found in Promise becomes bypassed. You may want to review this aspect yourself.
Pull Request #27: Make force work in conditions for futures, not only promises.

19 of 19 new or added lines in 3 files covered. (100.0%)

238 of 238 relevant lines covered (100.0%)

46.43 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25.1 (1.9.3) 17 May 2016 02:56PM UTC 0
99.51
Travis Job 25.1
2 25.2 (2.1.6) 17 May 2016 02:57PM UTC 0
99.51
Travis Job 25.2
3 25.3 (2.2.3) 17 May 2016 02:57PM UTC 0
99.51
Travis Job 25.3
5 25.5 (rbx-2) 17 May 2016 02:57PM UTC 0
100.0
Travis Job 25.5
Source Files on build 25
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #25
  • Pull Request #27
  • PR Base - master (#24)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc