Khan / perseus / 5932920478

69%

push

github

[🔥AUDIT🔥] Fix npm snapshots so they really don't run for Changeset PRs (#686)

🖍 _This is an audit!_ 🖍

## Summary:

The Perseus repository is set up to publish an npm snapshot for any non-draft PR. When creating the snapshot, we also check if there are any changesets before attempting to publish a snapshot, because the `changeset` tool will fail if there aren't any. 

When the `Version Packages` PR workflows run, all changeset files are being deleted and migrated to `CHANGELOG` files in each package. As a result, there are no changesets and so the `yarn changeset` command we use to publish the snapshot fails.

So this PR fixes our check and ensures we don't run the npm snapshot workflow for the special `Version Packages` PRs.

### Details of the fix

I originally thought I'd fixed this issue by comparing the `github.ref` value. It appears that in PRs, that value is not `refs/heads/chagneset-release/main` but rather `refs/remotes/pull/685/merge` (a PR branch). Reading Github's docs more closely, I found that `github.ref_name` is what I want, it is the friendly name of the PR branch as it appears in the Github UI.

Issue: "none"

## Test plan:

We'll have to monitor future "Version Packages" PRs and make sure the npm snapshot workflow doesn't run.

Author: jeremywiebe

Auditors: #perseus

Required Reviewers:

Approved By:

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/686

7625 of 16592 branches covered (45.96%)

Branch coverage included in aggregate %.

71446 of 97473 relevant lines covered (73.3%)

709.84 hits per line