basilisp-lang / basilisp / 5927053952

99%

push

github

Support sort-by maps and boolean comparison fns. (#709)

Hi,

could you please review update to support sorting maps with `sort-by`,
and also accepting boolean comparator fns in the same. It partly
addresses #708.

Basically, maps were delegating sorting to the immutables libraries,
which returns the keys of the maps when sorting; this patch converts
them into a sequence of key/value pairs, which is what Clojure uses to
return the result.

Boolean comparators were not working and are now converted to 3 way
comparator using the new `_fn_to_comparator` fn.

Since now the sorting is done on key/value vector pairs, it came to my
attention that the `vector.__lt__` which the sorting is delegating to,
was not working as expected, and thus updated to work according to how
Clojure thinks about vector comparison.

I've added test for all of the above.

I haven't touched `sort` much yet, wanted first to discuss this patch
first.

Thanks

---------

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1641 of 1643 branches covered (99.88%)

Branch coverage included in aggregate %.

41 of 41 new or added lines in 2 files covered. (100.0%)

7707 of 7785 relevant lines covered (99.0%)

0.99 hits per line