IntelPython / dpctl / 5906987980

86%

Build Type

push

github

Committed by web-flow

Commit Message

Fully enable ``usm_ndarray`` in-place arithmetic operators (#1352)

* Binary elementwise functions can now act on any input in-place
- A temporary will be allocated as necessary (i.e., when arrays overlap, are not going to be cast, and are not the same logical arrays)
- Uses dedicated in-place kernels where they are implemented
- Now called directly by Python operators
- Removes _inplace method of BinaryElementwiseFunc class
- Removes _find_inplace_dtype function

* Tests for new out parameter behavior for add

* Broadcasting made conditional in binary functions where memory overlap is possible
- Broadcasting can change the values of strides without changing array shape

* Changed exception types raised

Use ExecutionPlacementError for CFD violations.
Use ValueError is types of input are as expected, but values are
not as expected.

* Adding tests to improve coverage

Removed tests expecting error raised in case of overlapping inputs.
Added tests guided by coverage report.

* Removed provably unreachable branches in _resolve_weak_types

Since o1_dtype_kind_num > o2_dtype_kind_num, o1 can be not be
weak boolean type, since it has the lowest kind number in the
hierarchy.

* All in-place operators now use call operator of BinaryElementwiseFunc

* Removed some redundant and obsolete tests
- Removed from test_floor_ceil_trunc, test_hyperbolic, test_trigonometric, and test_logaddexp
- These tests would fail on GPU but never run on CPU, and therefore were not impacting the coverage
- These tests focused on aspects of the BinaryElementwiseFunc class rather than the behavior of the operator

---------

Co-authored-by: Oleksandr Pavlyk <oleksandr.pavlyk@intel.com>

Run Details

2323 of 2748 branches covered (84.53%)

Branch coverage included in aggregate %.

60 of 70 new or added lines in 2 files covered. (85.71%)

1 existing line in 1 file now uncovered.

8458 of 9849 relevant lines covered (85.88%)

7969.03 hits per line