5874758572
66%

Ran 16 Aug 2023 05:42AM UTC

Jobs 1

Files 250

Run time 6s

Badge

Embed ▾

Committed 16 Aug 2023 04:47AM UTC coverage: 67.279% (-0.1%) from 67.404%

Build # 5874758572

Build Type

push

Committed by

web-flow

Commit Message

fix(cdc): skip bad events in CDC (#8076)

A CDC event can return an error during JSON marshalling like the
following. This change skips these events from being sent to CDC.

2021/10/12 21:58:11 json: error calling MarshalJSON for type time.Time:
Time.MarshalJSON: year outside of range [0,9999]

    github.com/dgraph-io/dgraph/x.Check
        /ext-go/1/src/github.com/dgraph-io/dgraph/x/error.go:42
    github.com/dgraph-io/dgraph/worker.(*CDC).processCDCEvents.func1
        /ext-go/1/src/github.com/dgraph-io/dgraph/worker/cdc_ee.go:207
    github.com/dgraph-io/dgraph/worker.(*CDC).processCDCEvents.func2
        /ext-go/1/src/github.com/dgraph-io/dgraph/worker/cdc_ee.go:295
    github.com/dgraph-io/dgraph/worker.(*CDC).processCDCEvents.func3
        /ext-go/1/src/github.com/dgraph-io/dgraph/worker/cdc_ee.go:331
    github.com/dgraph-io/dgraph/worker.(*CDC).processCDCEvents
        /ext-go/1/src/github.com/dgraph-io/dgraph/worker/cdc_ee.go:351
    runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1371

Co-authored-by: Aman Mangal <aman@dgraph.io>

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

58593 of 87089 relevant lines covered (67.28%)

2234806.44 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
2	48.3	-0.46%	worker/cdc_ee.go

Uncovered Existing Lines

Lines	Coverage	∆	File
1	89.41	-0.59%	posting/oracle.go
1	88.33	-0.17%	schema/schema.go
2	84.92	1.01%	dgraph/cmd/zero/assign.go
2	83.12	0.0%	edgraph/server.go
2	84.91	0.97%	worker/groups.go
2	60.05	-0.23%	x/x.go
4	83.94	-2.07%	conn/raft_server.go
4	82.04	0.0%	worker/task.go
5	85.03	-0.77%	worker/mutation.go
6	84.93	-8.22%	posting/writer.go
6	88.69	-3.57%	worker/schema.go
7	83.52	-1.3%	conn/node.go
7	81.13	-1.41%	dgraph/cmd/zero/oracle.go
14	71.52	-1.74%	dgraph/cmd/zero/raft.go
107	43.53	-0.47%	protos/pb/pb.pb.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	5874758572.1	16 Aug 2023 05:42AM UTC	250	67.28

dgraph-io / dgraph / 5874758572
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 5874758572

dgraph-io / dgraph / 5874758572 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 5874758572

dgraph-io / dgraph / 5874758572
66%

README BADGES
x