Khan / perseus / 5872894963

69%

Build Type

push

github

Committed by web-flow

Commit Message

Roll v2 Keypad Onto Desktop Web (#645)

https://github.com/Khan/perseus/assets/23404711/b199ff5b-9db6-4394-8ef3-120531564ab3

Updates Perseus / Math Input to use keypad.

Also changes how it's used: 

- Instead of a set of keys appearing on focus, the button on the right acts as a toggle.
- Instead of a warning icon appearing when there is an parsing, the input shows a red "invalid" state and a tooltip appears with a friendly message.
- ~~There is no longer a `buttonsVisible` prop, since visibility is managed by the toggle. I believe this disabled the buttons in some cases. @jeremywiebe do we still need that ability?~~
  - This has been restored. The three states are:
    - `focused` default behavior, toggle off to start
    - `always` default behavior, toggle on to start
    - `never` toggle button disabled
- ~~`buttonSets` went from "any" that seemed to take an array to an object with fields that reflect the props on Keypad that toggle the presence of tabs.~~
  - `buttonSets` type was restored but marked deprecated in jsDocs
    - `keypadButtonSets` prop added that takes new type
    - `buttonSets` maps to `keypadButtonSets`
- Also adds optional `extraKeys` prop that takes an array of `Keys`.

Author: nedredmond

Reviewers: jeremywiebe, nedredmond, handeyeco

Required Reviewers:

Approved By: jeremywiebe, jeremywiebe

Checks: ✅ finish_coverage, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald, ✅ Check for .changeset file (ubuntu-latest, 16.x)

Pull Request URL: https://github.com/Khan/perseus/pull/645

Run Details

7584 of 16583 branches covered (45.73%)

Branch coverage included in aggregate %.

318 of 341 new or added lines in 3 files covered. (93.26%)

23 existing lines in 3 files now uncovered.

71130 of 96995 relevant lines covered (73.33%)

716.34 hits per line