Khan / perseus / 5868771377

69%

Build Type

push

github

Committed by web-flow

Commit Message

Migrated ArticleRenderer to Typescript types (#663)

## Summary:

I was adding some unit tests in a repo that uses the ArticleRenderer and noticed the types for ArticleRenderer were somewhat anemic. So given it was a late Friday afternoon I took a small detour and improved them. 

This PR improves our types for the article renderer a few ways:
  * Move ArticleRenderer to TS Props from PropTypes
  * Specify ProvideKeypad mixin types by defining 'this' parameter
  * Move math-input's prop-types file to TS

Issue: "none"

## Test plan:

`yarn typecheck`
`yarn test`

Author: jeremywiebe

Reviewers: nedredmond, kevinbarabash, handeyeco, SonicScrewdriver

Required Reviewers:

Approved By: nedredmond

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/663

Run Details

7687 of 16545 branches covered (46.46%)

Branch coverage included in aggregate %.

62 of 68 new or added lines in 8 files covered. (91.18%)

1 existing line in 1 file now uncovered.

71014 of 96825 relevant lines covered (73.34%)

713.14 hits per line