• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 5868771377
69%

Build:
DEFAULT BRANCH: main
Ran 15 Aug 2023 03:25PM UTC
Jobs 2
Files 528
Run time 18s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
5868771377

push

github

web-flow
Migrated ArticleRenderer to Typescript types (#663)

## Summary:

I was adding some unit tests in a repo that uses the ArticleRenderer and noticed the types for ArticleRenderer were somewhat anemic. So given it was a late Friday afternoon I took a small detour and improved them. 

This PR improves our types for the article renderer a few ways:
  * Move ArticleRenderer to TS Props from PropTypes
  * Specify ProvideKeypad mixin types by defining 'this' parameter
  * Move math-input's prop-types file to TS

Issue: "none"

## Test plan:

`yarn typecheck`
`yarn test`

Author: jeremywiebe

Reviewers: nedredmond, kevinbarabash, handeyeco, SonicScrewdriver

Required Reviewers:

Approved By: nedredmond

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/663

7687 of 16545 branches covered (46.46%)

Branch coverage included in aggregate %.

62 of 68 new or added lines in 8 files covered. (91.18%)

1 existing line in 1 file now uncovered.

71014 of 96825 relevant lines covered (73.34%)

713.14 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
1 jest 5868771377.1 15 Aug 2023 03:36PM UTC 0
63.58
GitHub Action Run
2 cypress 5868771377.2 15 Aug 2023 03:25PM UTC 0
26.36
GitHub Action Run
Source Files on build 5868771377
Detailed source file information is not available for this build.
  • Back to Repo
  • 410d490d on github
  • Prev Build on main (#5861213092)
  • Next Build on main (#5869431093)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc