Khan / perseus / 5859434647

69%

push

github

Prettier formatting check fix (#662)

## Summary:

In the first iteration of the Github check for source formatting, I was trying to use the Github action output format that allowed us to annotate the specific lines that were in violation (using `prettier --list-different | sed ...`).  This worked, but didn't fail the job because `sed` always returns `0` unless there's an execution error. 

So, instead of spending more time on that, I've reverted to the simpler `prettier --check` command which will print out failing files. Github won't annotate the specific lines in the PR, but I think that's not a big issue as the fix will pretty much always be to run `yarn format` in the PR nad commit the changes. 

Issue: "none"

## Test plan:

Introduce a formatting issue.
Push the commit. 
Check that the Github action fails. 
Fix the change. 
Push the commit. 
Check that the Github action passes.

Author: jeremywiebe

Reviewers: jeresig, #perseus, handeyeco

Required Reviewers:

Approved By: jeresig

Checks: ✅ gerald, ✅ finish_coverage, ⏭  Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/662

7687 of 16543 branches covered (46.47%)

Branch coverage included in aggregate %.

71015 of 96822 relevant lines covered (73.35%)

713.19 hits per line