Khan / perseus / 5858214692

69%

push

github

Fix keypad expansion on hover (#660)

Fixes bug where hover and focus caused border width to increase, triggering the grid to dynamically resize itself, which would be problematic for motion-sensitive learners.

Breaks up border styles to more easily maintain consistency in different states.


https://github.com/Khan/perseus/assets/23404711/7d777a5e-afb8-4ef9-8c68-1ab7789c3018

Author: nedredmond

Reviewers: handeyeco, nixterrimus, jeremywiebe, SonicScrewdriver

Required Reviewers:

Approved By: handeyeco

Checks: ✅ finish_coverage, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/660

7685 of 16535 branches covered (46.48%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

70949 of 96758 relevant lines covered (73.33%)

713.75 hits per line