release-engineering / waiverdb / 5852444409

84%

push

github

waivers/+filtered API endpoint: handle scenarios (#431) (#105)

The FilteredWaiversResource method which backs this endpoint
tries to find only 'current' waivers by grouping all waivers
by subject_type, subject_identifier and testcase, then taking
only the highest-numbered waiver from each group. This breaks if
we have multiple waivers for the same subject and testcase but
with different scenarios - the endpoint will only return one
waiver, the one with the highest ID, and will not return the
valid and current waivers for other scenarios as it should.

Signed-off-by: Adam Williamson <awilliam@redhat.com>

304 of 404 branches covered (75.25%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

961 of 1145 relevant lines covered (83.93%)

0.84 hits per line