hathitrust / hathitrust_catalog_indexer / 5833663304

92%

push

github

Add sane defaults for logfile names (#36)

* Add sane defaults for logfile names

Examples:
  cictl index today --log today
  cictl index full --log full
  cictl index today --log something_different.log (will go to <logdir>/something_different.log)

A few changes:
  * new module `CICTL::LogfileDefaults` that defines
    date_named_file templates and default values
    for daily/full index logs
  * logfile_directory is now separated from logfile
    name, initially set with `ENV["LOG_DIR"]` in and
    `Services` and updated thereafter with
    `CICTL::LogfileDefaults.logdir=`
  * Added magic names to send to `--log`:
    * `today` or `daily` gives `daily_YYYYMMDD.log`
    * `full` gives `full_YYYYMMDD.log`
    * any other string gives the name of a
      logfile _within the logdir_
  * Added a `--quiet` option to suppress all
    STDERR output (normally it shows errors/fatals)
  * Added a quick log spec that actually works because
    it checks the file, not stderr
  * Changed rspec tests to clean up logfile after running
  * Use `SemanticLogger.sync!` instead of `logger.close` to keep tests from hanging

---------

Co-authored-by: moseshll <moseshll@umich.edu>

42 of 52 new or added lines in 4 files covered. (80.77%)

837 of 927 relevant lines covered (90.29%)

1179.65 hits per line