tari-project / tari / 5797368271

62%

push

github

fix: miner delay attack (#5582)

Description
---
Stops the node blocking until it has a full block

Audit Finding Number
---
TARI-0001, TARI-0002

Motivation and Context
---
Its possible for a malicious node to block access to the full block by
using first the mempool to say it does not have the missing
transactions, then when asked for the full block to only then provide
the full block. But these requests can be made slow to delay the node
constructing the new block by almost 2 mins. This is the block time.

By only accepting 1 block request at a time, a malicious node can lock
down the local node for that entire 2 mins knowing they wont accept any
other blocks. This changes it so that nodes can still process new
requests. The first complete block will be served first.


Also changes the display of block information to ensure block sorted is
correctly used.

---------

Co-authored-by: Stan Bondi <sdbondi@users.noreply.github.com>

33 of 33 new or added lines in 1 file covered. (100.0%)

70351 of 92673 relevant lines covered (75.91%)

203404.21 hits per line