goto / compass / 5734607831
81%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.518% (-0.2%) from 87.69%
5734607831

push

github

web-flow 
feat: instrument service with OpenTelemetry (#47)

- Add Config.Telemetry for configuring Newrelic and OpenTelemetry.
- Deprecate Config.Newrelic - recommended to use
  Config.Telemetry.Newrelic instead.
- Deprecate Newrelic.Appname - recommended to use
  Config.Telemetry.AppName instead.
- Instrument the following:
  - internal/server/v1beta1.APIServer: Counter for compass.asset.update
    with the following attributes:
    - compass.update_method: asset_upsert_patch/asset_upsert/
      asset_upsert_patch_without_lineage.
    - asset.type: job/table etc.
    - asset.service: caramlstore/firehose etc.
    - operation.success: true/false.
  - core/asset/service.Service: Counter for compass.asset.operation with
    the following attributes:
    - compass.asset_operation: GetAssetByID/GetAssetByVersion/
      DeleteAsset.
    - asset.identifier: UUID/URN
    - operation.success: true/false.
  - internal/store/elasticsearch.DiscoveryRepository: Histogram for
    compass.es.client.duration with the following attributes:
    - es.operation: search/index_exists/create_index/index/
      delete_by_query.
    - es.status_code: ok/mapper_parsing_exception/
      cluster_block_exception.
    - compass.discovery_operation: Search/GroupAssets/Suggest/Upsert/
      DeleteByID/DeleteByURN.
- Integrate OpenTelemetry libraries:
  - https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/host
  - https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/google.golang.org/grpc/otelgrpc
  - https://github.com/nhatthm/otelsql
  - https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation/runtime

Co-authored-by: Haveiss <haveiss@users.noreply.github.com>

275 of 275 new or added lines in 10 files covered. (100.0%)

6107 of 6978 relevant lines covered (87.52%)

22.12 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
85.19
 -6.48% core/asset/errors.go
2
97.5
 -1.02% core/asset/service.go
2
79.25
 -1.61% internal/server/v1beta1/server.go
4
81.56
 -1.25% pkg/worker/pgq/pgq_processor.go
6
62.79
 1.15% internal/store/postgres/postgres.go
8
74.83
 6.79% internal/store/elasticsearch/es.go
19
67.97
 5.11% internal/store/elasticsearch/discovery_repository.go
23
81.23
 -1.94% internal/store/elasticsearch/discovery_search_repository.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
67.97
 5.11% internal/store/elasticsearch/discovery_repository.go
1
74.83
 6.79% internal/store/elasticsearch/es.go
1
62.79
 1.15% internal/store/postgres/postgres.go
3
81.23
 -1.94% internal/store/elasticsearch/discovery_search_repository.go
Jobs
ID Job ID Ran Files Coverage
1 5734607831.1 73
87.52
 GitHub Action Run
Source Files on build 5734607831