skeema / skeema / 5720234941

92%

push

github

diff/push: support SRID column attribute in MySQL 8+

This commit adds the ability to diff tables containing spatial columns with
SRID attributes in MySQL 8+. Previously, these tables were unsupported for
diff operations, meaning that `skeema diff` / `skeema push` would skip them
and log a warning.

Note that spatial columns alone (with no SRID, in any DB flavor/version) were
already supported. Meanwhile spatial indexes are not supported yet, but will
be added in a subsequent commit.

Also note MariaDB's equivalent attribute, REF_SYSTEM_ID, is unfortunately not
exposed by SHOW CREATE TABLE. This means tables using REF_SYSTEM_ID were
already supported for diff operations; however, `skeema init` and `skeema
pull` will strip REF_SYSTEM_ID attributes from .sql files. It is very likely
that `mysqldump` / `mariadb-dump` has the same issue on MariaDB, as this
would need to be fixed in the MariaDB server itself in order to work properly
in Skeema.

20 of 20 new or added lines in 2 files covered. (100.0%)

9217 of 9885 relevant lines covered (93.24%)

1.11 hits per line